Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local registry in NPR App #1081

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Use local registry in NPR App #1081

merged 13 commits into from
Nov 14, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Nov 13, 2024 •
edited
Loading

  • Use LocalRegistry for NPR canister.
  • Update IC dependencies

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner November 13, 2024 19:50
sasa-tomic
sasa-tomic approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit dee4d21 into main Nov 14, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the use-registry-for-NPR-computation branch November 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @sasa-tomic